Disable chunked prefill and/or prefix caching when MLA is enabled #12642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mgoin <[email protected]>
Signed-off-by: mgoin <[email protected]>
Signed-off-by: simon-mo <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Signed-off-by: simon-mo <[email protected]>
mgoin
approved these changes
Feb 1, 2025
ywang96
reviewed
Feb 1, 2025
Comment on lines
+3232
to
+3233
| self.scheduler_config.enable_chunked_prefill = False | ||
| self.scheduler_config.chunked_prefill_enabled = False |
There was a problem hiding this comment.
I never knew we had these two different flags, what's the difference?
Isotr0py
pushed a commit
to Isotr0py/vllm
that referenced
this pull request
Feb 2, 2025
…lm-project#12642) From @mgoin in vllm-project#12638 I cannot push to that branch, therefore a new PR to unblock release. --------- Signed-off-by: mgoin <[email protected]> Signed-off-by: simon-mo <[email protected]> Co-authored-by: mgoin <[email protected]> Signed-off-by: Isotr0py <[email protected]>
youngkent
pushed a commit
to youngkent/vllm
that referenced
this pull request
Feb 3, 2025
…lm-project#12642) From @mgoin in vllm-project#12638 I cannot push to that branch, therefore a new PR to unblock release. --------- Signed-off-by: mgoin <[email protected]> Signed-off-by: simon-mo <[email protected]> Co-authored-by: mgoin <[email protected]>
srikanthsrnvs
pushed a commit
to srikanthsrnvs/vllm
that referenced
this pull request
Feb 3, 2025
…lm-project#12642) From @mgoin in vllm-project#12638 I cannot push to that branch, therefore a new PR to unblock release. --------- Signed-off-by: mgoin <[email protected]> Signed-off-by: simon-mo <[email protected]> Co-authored-by: mgoin <[email protected]> Signed-off-by: Srikanth Srinivas <[email protected]>
sahelib25
pushed a commit
to krai/vllm
that referenced
this pull request
Feb 3, 2025
…lm-project#12642) From @mgoin in vllm-project#12638 I cannot push to that branch, therefore a new PR to unblock release. --------- Signed-off-by: mgoin <[email protected]> Signed-off-by: simon-mo <[email protected]> Co-authored-by: mgoin <[email protected]>
fxmarty-amd
pushed a commit
to fxmarty-amd/vllm
that referenced
this pull request
Feb 7, 2025
…lm-project#12642) From @mgoin in vllm-project#12638 I cannot push to that branch, therefore a new PR to unblock release. --------- Signed-off-by: mgoin <[email protected]> Signed-off-by: simon-mo <[email protected]> Co-authored-by: mgoin <[email protected]> Signed-off-by: Felix Marty <[email protected]>
NickLucche
pushed a commit
to NickLucche/vllm
that referenced
this pull request
Feb 7, 2025
…lm-project#12642) From @mgoin in vllm-project#12638 I cannot push to that branch, therefore a new PR to unblock release. --------- Signed-off-by: mgoin <[email protected]> Signed-off-by: simon-mo <[email protected]> Co-authored-by: mgoin <[email protected]>
|
Why was this change required. We are concerned we are seeing instability in the VLLM server with chunked prefill disabled. We are observing the server hangs when it receives a large prompt while other requests are in flight. Thank you. |
|
@siddartha-RE MLA does not supported chunked prefill yet, so it will error if you try to run it with that enabled. We are working on enabling this ASAP |
|
Thank you for the explanation. We are testing on 16x GH200 with 96GB per GPU. Let me know if you would like me to verify / benchmark anything on this configuration. |
ShangmingCai
pushed a commit
to ShangmingCai/vllm
that referenced
this pull request
Feb 10, 2025
…lm-project#12642) From @mgoin in vllm-project#12638 I cannot push to that branch, therefore a new PR to unblock release. --------- Signed-off-by: mgoin <[email protected]> Signed-off-by: simon-mo <[email protected]> Co-authored-by: mgoin <[email protected]>
GWS0428
pushed a commit
to GWS0428/VARserve
that referenced
this pull request
Feb 12, 2025
…lm-project#12642) From @mgoin in vllm-project#12638 I cannot push to that branch, therefore a new PR to unblock release. --------- Signed-off-by: mgoin <[email protected]> Signed-off-by: simon-mo <[email protected]> Co-authored-by: mgoin <[email protected]>
panf2333
pushed a commit
to yottalabsai/vllm
that referenced
this pull request
Feb 18, 2025
…lm-project#12642) From @mgoin in vllm-project#12638 I cannot push to that branch, therefore a new PR to unblock release. --------- Signed-off-by: mgoin <[email protected]> Signed-off-by: simon-mo <[email protected]> Co-authored-by: mgoin <[email protected]>
kerthcet
pushed a commit
to kerthcet/vllm
that referenced
this pull request
Feb 21, 2025
…lm-project#12642) From @mgoin in vllm-project#12638 I cannot push to that branch, therefore a new PR to unblock release. --------- Signed-off-by: mgoin <[email protected]> Signed-off-by: simon-mo <[email protected]> Co-authored-by: mgoin <[email protected]>
1 task
lk-chen
pushed a commit
to lk-chen/vllm
that referenced
this pull request
Mar 5, 2025
…lm-project#12642) From @mgoin in vllm-project#12638 I cannot push to that branch, therefore a new PR to unblock release. --------- Signed-off-by: mgoin <[email protected]> Signed-off-by: simon-mo <[email protected]> Co-authored-by: mgoin <[email protected]> Signed-off-by: Linkun Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From @mgoin in #12638
I cannot push to that branch, therefore a new PR to unblock release.