Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] fix pre-commit error #12494

Merged
merged 2 commits into from
Jan 28, 2025
Merged

[CI] fix pre-commit error #12494

merged 2 commits into from
Jan 28, 2025

Conversation

MengqingCao
Copy link
Contributor

@MengqingCao MengqingCao commented Jan 28, 2025 •
edited by github-actions bot
Loading

fix pre-commit error

@MengqingCao
[CI] fix pre-commit error
2476160 
Signed-off-by: Mengqing Cao <[email protected]>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@MengqingCao
fix typo
f206ccd 
Signed-off-by: Mengqing Cao <[email protected]>
jeejeelee
jeejeelee approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@jeejeelee jeejeelee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fixing,LGTM

@jeejeelee jeejeelee added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 28, 2025
@DarkLight1337 DarkLight1337 mentioned this pull request Jan 28, 2025
Merged
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) January 28, 2025 03:22
@DarkLight1337 DarkLight1337 mentioned this pull request Jan 28, 2025
Closed
@DarkLight1337 DarkLight1337 merged commit dd66fd2 into vllm-project:main Jan 28, 2025
63 checks passed
rasmith pushed a commit to rasmith/vllm that referenced this pull request Jan 30, 2025
@MengqingCao @rasmith
[CI] fix pre-commit error (vllm-project#12494)
1d96751 
Signed-off-by: Mengqing Cao <[email protected]>
Isotr0py pushed a commit to Isotr0py/vllm that referenced this pull request Feb 2, 2025
@MengqingCao @Isotr0py
[CI] fix pre-commit error (vllm-project#12494)
a36e7b0 
Signed-off-by: Mengqing Cao <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
NickLucche pushed a commit to NickLucche/vllm that referenced this pull request Feb 7, 2025
@MengqingCao @NickLucche
[CI] fix pre-commit error (vllm-project#12494)
b17cf22 
Signed-off-by: Mengqing Cao <[email protected]>
ShangmingCai pushed a commit to ShangmingCai/vllm that referenced this pull request Feb 10, 2025
@MengqingCao @ShangmingCai
[CI] fix pre-commit error (vllm-project#12494)
4ed9620 
Signed-off-by: Mengqing Cao <[email protected]>
GWS0428 pushed a commit to GWS0428/VARserve that referenced this pull request Feb 12, 2025
@MengqingCao @GWS0428
[CI] fix pre-commit error (vllm-project#12494)
6364d7d 
Signed-off-by: Mengqing Cao <[email protected]>
panf2333 pushed a commit to yottalabsai/vllm that referenced this pull request Feb 18, 2025
@MengqingCao @panf2333
[CI] fix pre-commit error (vllm-project#12494)
4c3d8cc 
Signed-off-by: Mengqing Cao <[email protected]>
kerthcet pushed a commit to kerthcet/vllm that referenced this pull request Feb 21, 2025
@MengqingCao @kerthcet
[CI] fix pre-commit error (vllm-project#12494)
d7cd359 
Signed-off-by: Mengqing Cao <[email protected]>
@MengqingCao MengqingCao deleted the ci_fix branch February 25, 2025 08:52
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Mar 5, 2025
@MengqingCao @lk-chen
[CI] fix pre-commit error (vllm-project#12494)
e837a81 
Signed-off-by: Mengqing Cao <[email protected]>
Signed-off-by: Linkun Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liangfu liangfu liangfu approved these changes

@mgoin mgoin mgoin approved these changes

@jeejeelee jeejeelee jeejeelee approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MengqingCao @liangfu @mgoin @jeejeelee @DarkLight1337