Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/Build] Fixed the xla nightly issue report in #12451 #12453

Merged
merged 4 commits into from
Jan 28, 2025

Conversation

hosseinsarshar
Copy link
Contributor

@hosseinsarshar hosseinsarshar commented Jan 26, 2025

The PR fixes the issue reported in bug #12451

FIX #12451

Context:

Apparently, there is an issue with the nightly XLA 2.7 release that is incompatible with the upstream torch 2.7, causing vLLM to break on TPUs.

I also reported this issue on the XLA repo (pytorch/xla#8626)

Resolution:

Matching the working combination - xla 2.7 dev20250124 with torch 2.6 dev20241216

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Jan 26, 2025
@DarkLight1337
Copy link
Member

cc @lsy323

@DarkLight1337 DarkLight1337 changed the title Fixed the xla nightly issue report in #12451 [Bugfix] Fixed the xla nightly issue report in #12451 Jan 27, 2025
@DarkLight1337 DarkLight1337 changed the title [Bugfix] Fixed the xla nightly issue report in #12451 [CI/Build] Fixed the xla nightly issue report in #12451 Jan 27, 2025
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) January 27, 2025 02:39
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 27, 2025
@DarkLight1337
Copy link
Member

Cancelled the CI as TPU tests are failing, please fix them.

auto-merge was automatically disabled January 27, 2025 15:12

Head branch was pushed to by a user without write access

@hosseinsarshar
Copy link
Contributor Author

Thanks @DarkLight1337 - fixed the issue - the tests should pass now

…the requirements.txt is fixed to solve the vLLM on TPU issue Signed-off-by: Hossein Sarshar [email protected]
torch_xla[pallas] @ https://storage.googleapis.com/pytorch-xla-releases/wheels/tpuvm/torch_xla-2.7.0.dev20250124-cp39-cp39-linux_x86_64.whl ; python_version == "3.9"
torch_xla[pallas] @ https://storage.googleapis.com/pytorch-xla-releases/wheels/tpuvm/torch_xla-2.7.0.dev20250124-cp310-cp310-linux_x86_64.whl ; python_version == "3.10"
torch_xla[pallas] @ https://storage.googleapis.com/pytorch-xla-releases/wheels/tpuvm/torch_xla-2.7.0.dev20250124-cp311-cp311-linux_x86_64.whl ; python_version == "3.11"
torch==2.6.0.dev20241216+cpu
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

torchxla nightly and torch nightly may not be compatible, due to c++ symbol issue. Please see the previous comment for detail.

@DarkLight1337 DarkLight1337 merged commit 23a7cbc into vllm-project:main Jan 28, 2025
70 checks passed
Isotr0py pushed a commit to Isotr0py/vllm that referenced this pull request Feb 2, 2025
@mgoin
Copy link
Member

mgoin commented Feb 20, 2025

@hosseinsarshar and @lsy323 the TPU runner is consistently failing in CI now due to the nightly version being removed from the index. I assume these are cleared over time. https://buildkite.com/vllm/ci/builds/13854#01952464-d826-4e96-8085-806bfa5483c7/42-148

Can you please look at fixing? Thanks

@hmellor hmellor mentioned this pull request Feb 24, 2025
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: the most recent xla nightly is breaking vllm on TPU
4 participants