-
-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[V1] Revert uncache_blocks
and support recaching full blocks
#12415
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Signed-off-by: Cody Yu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the API! LGTM.
…project#12415) Signed-off-by: Cody Yu <[email protected]> Signed-off-by: Felix Marty <[email protected]>
…project#12415) Signed-off-by: Cody Yu <[email protected]>
…project#12415) Signed-off-by: Cody Yu <[email protected]>
…project#12415) Signed-off-by: Cody Yu <[email protected]>
…project#12415) Signed-off-by: Cody Yu <[email protected]> Signed-off-by: Linkun Chen <[email protected]>
Revert #12333 as we realized that it's unsafe to uncache a block because it may be used by more than one requests. On the other hand, this PR supports
_cache_full_blocks
to deal with the already cached blocks, so that speculative decoding can use it in the following way:cc @LiuXiaoxuanPKU