[Hardware][Ascend] Add silu_and_mul/rope; Add mix ops into attention layer #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 7, 2025 12:40
Signed-off-by: hw_whx <[email protected]>
…ease Signed-off-by: hw_whx <[email protected]>
wuhuikx
reviewed
Feb 8, 2025
| from vllm.model_executor.layers.rotary_embedding import RotaryEmbedding | ||
|
|
||
|
|
||
| def rope_forward_oot( |
There was a problem hiding this comment.
out of tree, which means plugin backend types in vllm
ganyi1996ppo
reviewed
Feb 8, 2025
ganyi1996ppo
reviewed
Feb 8, 2025
Signed-off-by: hw_whx <[email protected]>
|
lgtm |
wuhuikx
approved these changes
Feb 8, 2025
ganyi1996ppo
approved these changes
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add silu_and_mul and rope ops;
Replace the original ops in attention impl with three mixed ops: reshape_and_cache, pagedattention and selfattention for better performance.