Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][UT]Update ut list #123

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[CI][UT]Update ut list #123

wants to merge 4 commits into from

Conversation

Potabk
Copy link
Contributor

@Potabk Potabk commented Feb 20, 2025

What this PR does / why we need it?

Enable vllm native ut:

tests/entrypoints/llm/test_init.py       
tests/entrypoints/llm/test_lazy_outlines.py
tests/entrypoints/test_chat_utils.py

Please note that the model:mistralai/Mistral-7B-Instruct-v0.1need apply for permissions to access

Does this PR introduce any user-facing change?

How was this patch tested?

--ignore=vllm-empty/tests/entrypoints/llm/test_guided_generate.py
--ignore=vllm-empty/tests/entrypoints/llm/test_encode.py
--ignore=vllm-empty/tests/entrypoints/llm/test_generate.py
--ignore=vllm-empty/tests/entrypoints/test_prompt_validation.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we ignore these test scripts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cause the scripts mentioned above may need download models weight from Amazon 3 warehouses, we need to add Authorization so that our runner can download the model normally

@wangxiyuan
Copy link
Collaborator

please update .github action to let e2e test run when pytest.ini is changed.

Potabk and others added 4 commits February 22, 2025 02:18
Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
Co-authored-by: Mengqing Cao <[email protected]>
Signed-off-by: wangli <[email protected]>
wangxiyuan pushed a commit that referenced this pull request Feb 26, 2025
### What this PR does / why we need it?
Add `HF_TOKEN` for downloading models that requires access rights from
huggingface hub. This will fix the CI error in #123 and #76

Signed-off-by: MengqingCao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants