feat: Add ingress configuration to routerSpec #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 0xThresh.eth <[email protected]>
|
Thanks for the contribution. Can you add a basic example of how to use the ingress? Could be in a separate PR if you want (we can create an issue to track this). |
|
Otherwise LGTM! |
|
Thanks @ApostaC, are you wanting that in the form of a tutorial or with more details in the Values? Ingresses are a bit opinionated based on which type of controller you use (NGINX, AWS load balancer, etc.), but I could try to add a tutorial using an NGINX ingress controller if you'd like. I would probably aim to do this in a separate PR since it might take me a few days to get back to. |
|
@0xThresh Since the issue is out there, I will merge this PR first. Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an ingress configuration to the routerSpec, enabling connections to the router service from outside the cluster.
Closes #28