feat: add configurable resource values to router deployment #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @0xThresh, thanks for creating the PR. and force push to your fork? More details can be found here: https://github.com/vllm-project/production-stack/pull/34/checks?check_run_id=36331245500 |
0xThresh
force-pushed
the
feat-resource-values
branch
from
c41c3bc to
f76478e
Compare
|
I'm working on fixing the pre-commit issues now, will have those pushed shortly |
Signed-off-by: 0xThresh.eth <[email protected]>
Signed-off-by: Ce Gao <[email protected]> Signed-off-by: 0xThresh.eth <[email protected]>
Updated tutorial minimal example filename. Signed-off-by: dmatch01 <[email protected]> Signed-off-by: 0xThresh.eth <[email protected]>
Updated tutorial file name reference for values minimal example. Signed-off-by: dmatch01 <[email protected]> Signed-off-by: 0xThresh.eth <[email protected]>
* Add pre-commit workflow * Add actionlint * Add generic hooks * Add black, isort, shellcheck * Add requirements and markdown linting * Add toml * Add Dockerfile * Add codespell * Use Node.js version of `markdownlint` * Add `requirements-lint.txt` * Use CLI version of Node.js `markdownlint` * Add `pre-commit` instructions to `Contributing` * `pre-commit run -a` automatic fixes * Exclude helm templates from `check-yaml` * Comment hooks that require installed tools * Make `codespell` happy * Make `actionlint` happy * Disable `shellcheck` until it can be installed properly * Make `markdownlint` happy * Add note about running pre-commit --------- Signed-off-by: Harry Mellor <[email protected]> Signed-off-by: 0xThresh.eth <[email protected]>
Signed-off-by: Shaoting Feng <[email protected]> Signed-off-by: 0xThresh.eth <[email protected]>
Signed-off-by: 0xThresh.eth <[email protected]>
0xThresh
force-pushed
the
feat-resource-values
branch
from
bbf73df to
95a0a29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.