Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Github workflows to lint and release Helm chart #23

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

0xThresh
Copy link
Contributor

@0xThresh 0xThresh commented Jan 26, 2025

This PR adds Github Actions workflows that can run helm lint on the Helm charts, and release Helm charts to Github using Github Pages as a publishing source.

Action Required - Set Up gh-pages Branch
Before the Helm release workflow will work correctly, there is setup required by a maintainer. The steps can be found in the Helm docs, and should only take about 5 minutes.

A successful test run of this workflow can be seen in my fork here: https://github.com/0xThresh/vllm-production-stack/actions/runs/12979140685/job/36194506180

And you can see the charts that I successfully published on my repo here: https://0xthresh.github.io/vllm-production-stack/index.yaml

While I hope this is a helpful PR, I also understand if there are other plans for chart publishing. If that is the case, I hope the Lint workflow is still helpful, and can update my PR to only include that. Thank you!

Copy link
Collaborator

@ApostaC ApostaC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution!

@ApostaC ApostaC merged commit 0a7e7f1 into vllm-project:main Jan 26, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants