Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually Enable LoRA Adapters using existing Router and vLLM deployment #206

Merged
merged 6 commits into from
Mar 2, 2025

Conversation

wangchen615
Copy link
Contributor

Progress toward #205

  • Make sure the code changes pass the pre-commit checks.
  • Sign-off your commit by using -s when doing git commit
  • [Feat] LoRA adapter manually enablement support
This PR just add some manually LoRA enablement tutorial, `tutorials/assets/values-07-lora-enabled.yaml` and simple deployment yaml template update to have an `enableLoRA: true` configuration for the helm chart.

tutorials/09-lora-enabled-installation.md describes how to manually add an adapter to an vllm deployment in production stack.

PR Title and Classification

  • [Feat] LoRA enablement support.
  • [Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.

@ApostaC ApostaC requested a review from YuhanLiu11 March 1, 2025 18:48
Signed-off-by: Chen Wang <[email protected]>
Signed-off-by: Chen Wang <[email protected]>
Signed-off-by: Chen Wang <[email protected]>
    edit cb23434 fix format issues
    edit 03d8e5f add values yaml for lora

Signed-off-by: Chen Wang <[email protected]>
@YuhanLiu11
Copy link
Collaborator

YuhanLiu11 commented Mar 1, 2025

Thanks @wangchen615 for your contribution! gonna take a look now.


```bash
# List available models before loading adapter
curl http://localhost:8000/v1/models
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similary here we'll probably need a different port. also for those 8000 port below.

Signed-off-by: Chen Wang <[email protected]>
@YuhanLiu11
Copy link
Collaborator

@wangchen615 Thanks for your contribution! Can you fix the pre-commit issue? (run pre-commit install before you commit )

Signed-off-by: Chen Wang <[email protected]>
Copy link
Collaborator

@YuhanLiu11 YuhanLiu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@YuhanLiu11 YuhanLiu11 merged commit 4119d15 into vllm-project:main Mar 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants