-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] Add advanced Kubernetes configuration options for router deployment #151
base: main
Are you sure you want to change the base?
[Feat] Add advanced Kubernetes configuration options for router deployment #151
Conversation
- Enhance values schema with comprehensive node, affinity, and service monitor configuration - Update values.yaml with new configuration options - Modify router deployment template to support nodeSelector, affinity, and tolerations - Add ServiceMonitor template for Prometheus metrics scraping - Update router service to use configurable port name Signed-off-by: Liad Drori <[email protected]>
Thanks for your contribution! We will take a look soon. |
I am getting the following error when enabling the service monitor: Could you provide instructions on installing Prometheus Operator? |
You can use any prometheus-operator install you want. For example you can install kube-prometheus-stack You just need to make sure you have the CRD's installed in your cluster |
Probably useful to include the example install of |
The code in this PR looks good to me. We have a basic setup script of kube-prometheus-stack here, so I guess using ServiceMonitor will be a better idea than customizing the values.yaml when deploying the kube Prometheus stack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@Shaoting-Feng @YuhanLiu11 when you have time, can you try enabling the ServiceMonitor with kube-prometheus-stack installed?
Description
This PR improves the Kubernetes configuration for router deployment by adding advanced scheduling and monitoring features.
Currently, monitoring requires installing prom-stack with custom configurations. The recommended approach is to provide an option to create a
ServiceMonitor
, enabling monitoring with any Prometheus Operator in the cluster.Key Changes
Advanced Scheduling Options
nodeSelector
,affinity
, andtolerations
in the router deploymentService Configuration Improvements
servicePortName
configurationMonitoring Integration with Existing Prometheus Stack
Technical Details
.Values.routerSpec.serviceMonitor.enabled
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
-s
when doinggit commit
[Bugfix]
,[Feat]
, and[CI]
.Detailed Checklist (Click to Expand)
Thank you for your contribution to production-stack! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]
for bug fixes.[CI/Build]
for build or continuous integration improvements.[Doc]
for documentation fixes and improvements.[Feat]
for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).[Router]
for changes to thevllm_router
(e.g., routing algorithm, router observability, etc.).[Misc]
for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
pre-commit
to format your code. SeeREADME.md
for installation.DCO and Signed-off-by
When contributing changes to this project, you must agree to the DCO. Commits must include a
Signed-off-by:
header which certifies agreement with the terms of the DCO.Using
-s
withgit commit
will automatically add this header.What to Expect for the Reviews
We aim to address all PRs in a timely manner. If no one reviews your PR within 5 days, please @-mention one of YuhanLiu11
, Shaoting-Feng or ApostaC.