-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable multi-GPU inference in vLLM with tensor parallelism #105
Conversation
Signed-off-by: YuhanLiu11 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also increase the minor version number in Chart.yaml (
production-stack/helm/Chart.yaml
Line 18 in d109e77
version: 0.0.3 |
This is to update the release helm charts on the github pages.
Also, please fix the problems in the functionality test. Seems like there will be an error if $modelSpec.vllmConfig does not exist. Thanks! |
Fixing it now! |
Signed-off-by: YuhanLiu11 <[email protected]>
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…ect#105) * Adding TP>1 support and adding shm size as a configurable parameter Signed-off-by: YuhanLiu11 <[email protected]> Signed-off-by: sitloboi2012 <[email protected]>
…ect#105) * Adding TP>1 support and adding shm size as a configurable parameter Signed-off-by: YuhanLiu11 <[email protected]> Signed-off-by: sitloboi2012 <[email protected]>
This PR introduces support for tensor parallelism in vLLM engines by modifying the Helm chart template to include shared memory configuration when tensorParallelSize is set. This enables multi-GPU execution with tensor parallelism degree of more than one.
FIX #95
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
PR Checklist (Click to Expand)
Thank you for your contribution to production-stack! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]
for bug fixes.[CI/Build]
for build or continuous integration improvements.[Doc]
for documentation fixes and improvements.[Feat]
for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).[Router]
for changes to thevllm_router
(e.g., routing algorithm, router observability, etc.).[Misc]
for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
pre-commit
to format your code. SeeREADME.md
for installation.DCO and Signed-off-by
When contributing changes to this project, you must agree to the DCO. Commits must include a
Signed-off-by:
header which certifies agreement with the terms of the DCO.Using
-s
withgit commit
will automatically add this header.What to Expect for the Reviews
We aim to address all PRs in a timely manner. If no one reviews your PR within 5 days, please @-mention one of YuhanLiu11
, Shaoting-Feng or ApostaC.