Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI/CD] Automatically build the router docker image via github action #74

Closed
ApostaC opened this issue Feb 7, 2025 · 3 comments · Fixed by #94
Closed

[CI/CD] Automatically build the router docker image via github action #74

ApostaC opened this issue Feb 7, 2025 · 3 comments · Fixed by #94
Assignees
@Sozhan308
Labels
feature request New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ApostaC
Copy link
Collaborator

ApostaC commented Feb 7, 2025

Right now, we don't have an automatic pipeline to build the docker image for the router.

Ideally, every time there is merged a PR about the router, there should be a GitHub action to automatically build the docker image and release it.

Also, when PR is created and ready to merge (not merged yet), there should be a way to trigger the end-to-end test pipeline to test the router.
@ApostaC ApostaC added the feature request New feature or request label Feb 7, 2025
@ApostaC ApostaC mentioned this issue Feb 6, 2025
Open
17 tasks
@gaocegege gaocegege added good first issue Good for newcomers help wanted Extra attention is needed labels Feb 7, 2025
@gaocegege
Copy link
Collaborator

Also, when PR is created and ready to merge (not merged yet), there should be a way to trigger the end-to-end test pipeline to test the router.

Do we have the end-to-end test for router now?

@gaocegege gaocegege mentioned this issue Feb 7, 2025
Open
@ApostaC
Copy link
Collaborator Author

ApostaC commented Feb 7, 2025

Do we have the end-to-end test for router now?

We have a functionality test for the whole helm chart, but not specifically for router.

@Sozhan308
Copy link
Contributor

Hi @ApostaC,

I’d really like to help out with this task. Let me know if I can take it on!

Sozhan308 added a commit to Sozhan308/production-stack that referenced this issue Feb 9, 2025
@Sozhan308
feat(ci): add GitHub Actions workflows for router (vllm-project#74)
e96f40e 
- Add router-e2e-test workflow for PR validation with performance tests
- Add router-docker-release workflow for automated image builds
Sozhan308 added a commit to Sozhan308/production-stack that referenced this issue Feb 9, 2025
@Sozhan308
feat(ci): add GitHub Actions workflows for router (vllm-project#74)
d6e9456 
- Add router-e2e-test workflow for PR validation with performance tests
- Add router-docker-release workflow for automated image builds

Signed-off-by: Sozhan Natarajan <[email protected]>
@Sozhan308 Sozhan308 mentioned this issue Feb 9, 2025
Merged
Sozhan308 added a commit to Sozhan308/production-stack that referenced this issue Feb 9, 2025
@Sozhan308
fix: update scripts for compatibility with CI infrastructure (vllm-pr…
8cf8631 
…oject#74)

- Enhance path handling in minikube and router scripts
- Update workflow configurations for better reliability
- Fix Python dependencies and test requirements
- Improve test environment setup and execution

Signed-off-by: Sozhan Natarajan <[email protected]>
ApostaC pushed a commit that referenced this issue Feb 9, 2025
@Sozhan308
[CI/Build] : add GitHub Actions workflows for router (#74) (#94)
95c9e8f 
* feat(ci): add GitHub Actions workflows for router (#74)
- Add router-e2e-test workflow for PR validation with performance tests
- Add router-docker-release workflow for automated image builds
- Enhance path handling in minikube and router scripts
- Update workflow configurations for better reliability
- Fix Python dependencies and test requirements
- Improve test environment setup and execution

Signed-off-by: Sozhan Natarajan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sozhan308 Sozhan308

Labels
feature request New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[CI/Build] : add GitHub Actions workflows for router (#74) Sozhan308/production-stack
3 participants
@gaocegege @Sozhan308 @ApostaC