Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI/Build] adopt uv #199

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[CI/Build] adopt uv #199

wants to merge 7 commits into from

Conversation

kemingy
Copy link

@kemingy kemingy commented Feb 28, 2025

FIX #184

BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE

  • Make sure the code changes pass the pre-commit checks.
  • Sign-off your commit by using -s when doing git commit
  • Try to classify PRs for easy understanding of the type of changes, such as [Bugfix], [Feat], and [CI].
Detailed Checklist (Click to Expand)

Thank you for your contribution to production-stack! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.

PR Title and Classification

Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

  • [Bugfix] for bug fixes.
  • [CI/Build] for build or continuous integration improvements.
  • [Doc] for documentation fixes and improvements.
  • [Feat] for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).
  • [Router] for changes to the vllm_router (e.g., routing algorithm, router observability, etc.).
  • [Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.

Code Quality

The PR need to meet the following code quality standards:

  • Pass all linter checks. Please use pre-commit to format your code. See README.md for installation.
  • The code need to be well-documented to ensure future contributors can easily understand the code.
  • Please include sufficient tests to ensure the change is stay correct and robust. This includes both unit tests and integration tests.

DCO and Signed-off-by

When contributing changes to this project, you must agree to the DCO. Commits must include a Signed-off-by: header which certifies agreement with the terms of the DCO.

Using -s with git commit will automatically add this header.

What to Expect for the Reviews

We aim to address all PRs in a timely manner. If no one reviews your PR within 5 days, please @-mention one of YuhanLiu11
, Shaoting-Feng or ApostaC.

@kemingy
Copy link
Author

kemingy commented Feb 28, 2025

Not sure why the setup.py requires 3.12 but some CI test pin 3.10.13.

BTW, copying the .git in the Dockerfile will usually disable all the following cache layers.

@YuhanLiu11
Copy link
Collaborator

@kemingy Thanks for the contribution! We will be looking at this soon!

cc @Shaoting-Feng

Shaoting-Feng
Shaoting-Feng reviewed Mar 3, 2025
View reviewed changes
Copy link
Collaborator

@Shaoting-Feng Shaoting-Feng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Could you help resolve the conflicts? Over the weekend, we added three packages for the router. Could you also include them in the pyproject.toml file?

@kemingy
Copy link
Author

kemingy commented Mar 4, 2025

Thanks for your contribution! Could you help resolve the conflicts? Over the weekend, we added three packages for the router. Could you also include them in the pyproject.toml file?

Rebased. PTAL.

@Shaoting-Feng
Copy link
Collaborator

Thanks for your fix. Could you help make the optioinal dependencies work consistently with the docker build phase? For example, the INSTALL_SENTENCE_TRANSFORMERS argument in the functionality test workflow.

@kemingy
Copy link
Author

kemingy commented Mar 4, 2025

Thanks for your fix. Could you help make the optioinal dependencies work consistently with the docker build phase? For example, the INSTALL_SENTENCE_TRANSFORMERS argument in the functionality test workflow.

Fixed.

kemingy added 2 commits March 5, 2025 17:35
@kemingy
rebase
9f95505 
Signed-off-by: Keming <[email protected]>
@kemingy
fix script path
9e824ae 
Signed-off-by: Keming <[email protected]>
@kemingy kemingy requested a review from Shaoting-Feng March 5, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shaoting-Feng Shaoting-Feng Awaiting requested review from Shaoting-Feng

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feature: introduce pyproject.toml and use uv
3 participants
@kemingy @YuhanLiu11 @Shaoting-Feng