Remove Storage Class dirty fix

Signed-off-by: hanchenli <[email protected]>
vllm-project · Feb 17, 2025 · 3eb259e · 3eb259e
1 parent 2d51bfd
commit 3eb259e
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 9 deletions.
diff --git a/deployment_on_cloud/aws/production_stack_specification.yaml b/deployment_on_cloud/aws/production_stack_specification.yaml
@@ -15,4 +15,4 @@ servingEngineSpec:
     pvcStorage: "40Gi"
     pvcAccessMode:
       - ReadWriteMany
-    storageClass: "efs_static_storage_class_indicator" #This is to let helm pvc know it should be empty string
+    storageClass: "" #This is to let helm pvc know it should be empty string
diff --git a/helm/Chart.yaml b/helm/Chart.yaml
@@ -15,7 +15,7 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.0.6
+version: 0.0.7
 
 maintainers:
   - name: apostac
diff --git a/helm/templates/pvc.yaml b/helm/templates/pvc.yaml
@@ -15,12 +15,8 @@ spec:
   resources:
     requests:
       storage: {{ $modelSpec.pvcStorage | default "20Gi" }}  # Default to 40Gi if not set
-  {{- if $modelSpec.storageClass }}
-    {{- if eq $modelSpec.storageClass "efs_static_storage_class_indicator" }}
-  storageClassName: ""
-    {{- else }}
-  storageClassName: "{{ $modelSpec.storageClass }}"
-    {{- end }}
+  {{- if hasKey $modelSpec "storageClass" }}
+    storageClassName: "{{ $modelSpec.storageClass }}"
   {{- end }}
   {{- if not (empty $modelSpec.pvcMatchLabels) }}
   selector:

diff --git a/tutorials/deployments/01-AWS-EKS-deployment.md b/tutorials/deployments/01-AWS-EKS-deployment.md
@@ -216,7 +216,7 @@ servingEngineSpec:
     pvcStorage: "40Gi"
     pvcAccessMode:
       - ReadWriteMany
-    storageClass: "efs_static_storage_class_indicator"
+    storageClass: ""
 ```
 
 ### Step 7 Stopping the Helm Cluster