Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gemma2 examples with a note about sample generation #1176

Merged
merged 2 commits into from
Feb 19, 2025
Merged

Update gemma2 examples with a note about sample generation #1176

merged 2 commits into from
Feb 19, 2025

Conversation

dsikka
Copy link
Collaborator

@dsikka dsikka commented Feb 19, 2025 •
edited
Loading

SUMMARY:

  • Add a note advising users to either downgrade transformers from 4.49 or use vLLM for generation
  • We should revisit why this is only happening on generation with this new release but can be revisited down the road

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

@dsikka dsikka added the ready When a PR is ready for review label Feb 19, 2025
@dsikka dsikka enabled auto-merge (squash) February 19, 2025 17:46
@dsikka dsikka merged commit 6a1ba3c into main Feb 19, 2025
8 checks passed
@dsikka dsikka deleted the update_gemma2 branch February 19, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-dellabetta brian-dellabetta brian-dellabetta approved these changes

@kylesayrs kylesayrs kylesayrs approved these changes

Assignees
No one assigned
Labels
ready When a PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsikka @brian-dellabetta @kylesayrs