-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timer support for testing #1137
Conversation
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
f3679c2
to
1e27161
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Job!
Can you expand on the CSV file contents and location (directory, filename)? Regarding location, we currently run the script that runs all the various configs for this test in sequence. I assume that this will not cause any existing files to be overwritten (e.g. each test's CSV file(s) will be uniquely named), but it also seems like they might end up scattered across different directories? Since they seem more like a test artifact than a model/etc. one, it seems like it might make more sense to gather them in a consolidated directory (which would also make finding them all programmatically after the tests conclude much simpler. As far as contents, just an example of the contents after a single test would be helpful. |
Yup, let me update the PR description to add more colour to what we're producing |
Customizable (e.g., via env var) would be nice, but even just a dedicated root folder (maybe something like I think aside from that, this all looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the ability to control the timing CSV output dir via env var, that will be very helpful, especially if we expand the usage of this timer to other tests.
Looks good to me!
This is awesome, thanks for adding it! |
SUMMARY:
For the following model produced from one test case: https://huggingface.co/nm-testing/TinyLlama-1.1B-Chat-v1.0-FP8_DYNAMIC-e2e
The following csv will be produced:
TinyLlama-1.1B-Chat-v1.0-FP8_DYNAMIC.csv
and the names will be unique as a result.The contents of the csv:
TIMINGS_DIR
env variableTEST PLAN: