Properly restore training mode with eval_context
#1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kyle Sayers <[email protected]>
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
brian-dellabetta
previously approved these changes
Feb 5, 2025
dsikka
reviewed
Feb 5, 2025
Signed-off-by: Kyle Sayers <[email protected]>
rahul-tuli
approved these changes
Feb 7, 2025
horheynm
reviewed
Feb 7, 2025
|
In general is there a bug or feature that this pr is fixing? Whats the problem we have now to include this feature? |
|
@horheynm I cannot point to specific issue which is caused by not restoring the training mode, but we're moving towards LLM Compressor being used in downstream training scripts, so it's good to harden out these side effects early before we encounter issues caused by them later. |
dsikka
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Changes
eval_context, which stores the original training state of the model