Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin pynvml to fix e2e test failures with vLLM #1125

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

dsikka
Copy link
Collaborator

@dsikka dsikka commented Feb 5, 2025

SUMMARY:

  • vLLM throws a runtime error if pynvml < 12.0 is installed
  • Unpin pynvml version to prevent error and allow e2e tests to run

TEST PLAN:

  • e2e tests now run

Copy link

github-actions bot commented Feb 5, 2025

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

@dsikka dsikka added the ready When a PR is ready for review label Feb 5, 2025
Copy link
Collaborator

@kylesayrs kylesayrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, we're not using any super volatile features of this library anyways

@dsikka dsikka enabled auto-merge (squash) February 5, 2025 20:43
@dsikka dsikka disabled auto-merge February 5, 2025 21:03
@dsikka dsikka merged commit 1094c38 into main Feb 5, 2025
8 checks passed
@dsikka dsikka deleted the update_pynvlm branch February 5, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready When a PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants