Use unique test names in TestvLLM
#1124
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
This PR updates the
TestvLLM
class to pass the config file being tested as a parameter to the test. Functionally, this is no different than the existing behavior with regards to the test, but practically, it means that the config file will be included in the generated test name making it much easier to identify which config file is being tested across the board (in console output, in Testmo/reporting tools, etc.).As a result, there is no longer a need for the previously added fixture that embedded the config file into the test suite metadata for downstream processing.
TEST PLAN:
A custom test run executing the e2e tests against this branch is here: https://github.com/neuralmagic/llm-compressor-testing/actions/runs/13138573134/job/36659921426
Reviewing the output of the 'run e2e tests' steps, the test names are updated:
TestvLLM.test_vllm
TestvLLM_0_tests_e2e_vLLM_configs_fp8_dynamic_per_token_yaml.test_vllm
Note: The failures (
RuntimeError: Failed to infer device type
) are expected due to a recent change (seemingly on the vLLM side).