Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise warning for 24 compressed sparse-only models #1107

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

rahul-tuli
Copy link
Collaborator

In a recent update, we disabled Cutlass kernels for sparse-only models vllm-project/vllm#12417. As a result, sparse-24-only compressed-models are no longer runnable in vLLM.

This PR introduces a warning message to inform users when compression is enabled in scenarios where sparse-only models are unsupported. This ensures clarity and avoids unexpected behavior when using sparse-24 configurations with vLLM.

Changes:

  • Added a warning to notify users when attempting to enable compression with sparse-only models in unsupported configurations.

Copy link

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

@rahul-tuli rahul-tuli marked this pull request as ready for review January 28, 2025 18:27
Copy link
Collaborator

@brian-dellabetta brian-dellabetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@horheynm
Copy link
Collaborator

horheynm commented Jan 28, 2025

LGTM, much clearer.
Looks like there are some commit contamination

Edit:
NVM wasn't up to date with main!

@rahul-tuli rahul-tuli force-pushed the raise-warning-for-sparse24-models branch from 9af4d8b to 81ce2ec Compare January 28, 2025 19:44
@dsikka dsikka merged commit b61092b into main Jan 28, 2025
7 checks passed
@dsikka dsikka deleted the raise-warning-for-sparse24-models branch January 28, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants