Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traceability Guide: Clarity and typo #1099

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Conversation

kylesayrs
Copy link
Collaborator

@kylesayrs kylesayrs commented Jan 26, 2025

Purpose

  • Reword some things and fix typo in tracing guide

Changes

  • No need to wrap numbers with code font
  • Activations are used to calibrate the hessian, not recorded into the hessian
  • Add close bracket for emphasis tag, which was causing the rest of the doc to be italicized

Signed-off-by: Kyle Sayers <[email protected]>
Copy link

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

@kylesayrs kylesayrs self-assigned this Jan 26, 2025
@kylesayrs kylesayrs added the ready When a PR is ready for review label Jan 26, 2025
Copy link
Collaborator

@brian-dellabetta brian-dellabetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dsikka dsikka merged commit a9b8654 into main Jan 27, 2025
7 checks passed
@dsikka dsikka deleted the kylesayrs/fix-traceability-typo branch January 27, 2025 18:55
rahul-tuli pushed a commit that referenced this pull request Jan 28, 2025
## Purpose ##
* Reword some things and fix typo in tracing guide

## Changes ##
* No need to wrap numbers with code font
* Activations are used to calibrate the hessian, not recorded into the
hessian
* Add close bracket for emphasis tag, which was causing the rest of the
doc to be italicized

Signed-off-by: Kyle Sayers <[email protected]>
Co-authored-by: Dipika Sikka <[email protected]>
Signed-off-by: Rahul Tuli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready When a PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants