Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add python 3.13 support to CMakeLists.txt #47

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add python 3.13 support to CMakeLists.txt #47

wants to merge 1 commit into from
+2 −2

Conversation

Ryp
Copy link

@Ryp Ryp commented Feb 17, 2025 •
edited
Loading

This matches the work done in 8878692 Python 3.8 was subsequently dropped as well here.

Related to vllm-project/vllm#13164

@Ryp
Add python 3.13 support to CMakeLists.txt
d690cf7 
This matches the work done in vllm-project@8878692
Python 3.8 was subsequently dropped as well here.

Signed-off-by: Thibault Schueller <[email protected]>
@mgoin
Copy link
Member

mgoin commented Feb 17, 2025

Could you please take a look @LucasWilkinson @WoosukKwon

@mgoin mgoin mentioned this pull request Feb 17, 2025
Draft
4 tasks
NickLucche
NickLucche suggested changes Feb 17, 2025
View reviewed changes
Copy link

@NickLucche NickLucche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just for dev or is this a python version bump of the whole project? If it's the latter we would need to change PYTHON_VERSION in the dockerfiles as well as the CI config files to make sure all deps are ok.

@Ryp
Copy link
Author

Ryp commented Feb 17, 2025

Is this just for dev or is this a python version bump of the whole project? If it's the latter we would need to change PYTHON_VERSION in the dockerfiles as well as the CI config files to make sure all deps are ok.

To the best of my knowledge python3.13 is already covered by the CI: https://github.com/vllm-project/flash-attention/blob/main/.github/workflows/publish.yml#L46

@LucasWilkinson
Copy link
Collaborator

Could you please take a look @LucasWilkinson @WoosukKwon

LGTM, but ill let the CI experts have the final word

@Ryp Ryp requested a review from NickLucche February 25, 2025 11:25
@Ryp
Copy link
Author

Ryp commented Feb 28, 2025

@NickLucche I think your requested review changes is preventing this PR to be merged

@mgoin
Copy link
Member

mgoin commented Feb 28, 2025

@WoosukKwon can you please merge? I do not have permission

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgoin mgoin mgoin approved these changes

@NickLucche NickLucche NickLucche approved these changes

@WoosukKwon WoosukKwon WoosukKwon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Ryp @mgoin @LucasWilkinson @NickLucche @WoosukKwon