Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add head dimension 80 to compiled kernels #22

Closed
wants to merge 1 commit into from

Conversation

njhill
Copy link
Member

@njhill njhill commented Oct 2, 2024

No description provided.

@WoosukKwon
Copy link

@njhill Can you please execute the generate_kernels.py and add the generated files for hdim80? I tried to add them by myself, but it seems your repo doesn't allow it.

@WoosukKwon
Copy link

@njhill Oh actually the compiled head size should be a multiple of 32 :(

static_assert(kHeadDim % 32 == 0);

@njhill
Copy link
Member Author

njhill commented Oct 2, 2024

ah, thanks @WoosukKwon :( .. I thought there might be something like that, sorry should have checked before I opened this

@WoosukKwon WoosukKwon closed this Oct 2, 2024
@njhill njhill deleted the headdim-80 branch October 3, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants