Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add rpm/tpm extension proc plugin #79

Merged
merged 7 commits into from
Aug 15, 2024
Merged

[feat] Add rpm/tpm extension proc plugin #79

merged 7 commits into from
Aug 15, 2024

Conversation

varungup90
Copy link
Collaborator

image

@Jeffwan
Copy link
Collaborator

Jeffwan commented Aug 14, 2024

@varungup90 for the folder naming, do you think it's better to use pkg/gateway or other names instead? we do not need to expose ext_proc in folder names.

please also help rebase the code and we can resolve the test failure

@Jeffwan
Copy link
Collaborator

Jeffwan commented Aug 15, 2024

@varungup90 will we have other plugins? do you think it's good to use root/pkg/gateway directly or root/plugins. I do not have strong preference on the naming, just want to have some discussion on this.

@Jeffwan
Copy link
Collaborator

Jeffwan commented Aug 15, 2024

/lgtm

@Jeffwan Jeffwan changed the title Add rpm/tpm extension proc plugin [feat] Add rpm/tpm extension proc plugin Aug 15, 2024
@Jeffwan Jeffwan merged commit af45221 into main Aug 15, 2024
1 check passed
@Jeffwan Jeffwan deleted the add-tpm branch August 15, 2024 23:05
gangmuk pushed a commit that referenced this pull request Jan 25, 2025
* Add rpm/tpm extension proc plugin

* add license header

* add extproc auto creation with httproute

* update go.mod

* address comments

* update plugin dir strcuture

---------

Co-authored-by: varungupta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants