Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix the golang lint issues #77

Merged
merged 2 commits into from
Aug 12, 2024
Merged

[CI] Fix the golang lint issues #77

merged 2 commits into from
Aug 12, 2024

Conversation

Jeffwan
Copy link
Collaborator

@Jeffwan Jeffwan commented Aug 12, 2024

Pull Request Description

Fix the existing linter reported issues to unblock the PR merge. Note, I disable unparam at this moment and it take some time to fix them in elegant way.

Related Issues

Resolves: #75

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@Jeffwan Jeffwan changed the title Jiaxin/fix linter issue [CI] Fix the golang lint issues Aug 12, 2024
@Jeffwan Jeffwan requested a review from M00nF1sh August 12, 2024 14:33
Copy link
Contributor

@M00nF1sh M00nF1sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@M00nF1sh
Copy link
Contributor

the UT seems passed, but E2E failed with HorizontalPodAutoscaler.autoscaling "test-resource-hpa" is invalid: [spec.scaleTargetRef.kind: Required value, spec.scaleTargetRef.name: Required value].
i think we can merge this and fix e2e separately

@Jeffwan Jeffwan merged commit fb01f7f into main Aug 12, 2024
1 check failed
@Jeffwan Jeffwan deleted the jiaxin/fix-linter-issue branch August 12, 2024 23:43
gangmuk pushed a commit that referenced this pull request Jan 25, 2025
* Disable unparam which can not be fixed now

* Fix linter issues that block PR check in
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Fix the lint issues and tests
2 participants