Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add optimizer-based autoscaling doc and examples #692

Merged
merged 3 commits into from
Feb 18, 2025

Conversation

nwangfw
Copy link
Collaborator

@nwangfw nwangfw commented Feb 17, 2025

Pull Request Description

This PR provides instruction on how to use optimizer-based autoscaling feature. It only covers case where there is single-type of GPU.

  • A optimizer-based pod autoscaling yaml example is provided.
  • A introduction of this feature and some preliminary experimental results are provided.

Related Issues

Resolves: #[Insert issue number(s)]

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@nwangfw nwangfw requested review from zhangjyr and Jeffwan February 17, 2025 18:51
@nwangfw nwangfw force-pushed the ning/gpu-optimizer-podautoscaling-docs branch 3 times, most recently from 0cda172 to 27dffb0 Compare February 17, 2025 19:16
@nwangfw nwangfw force-pushed the ning/gpu-optimizer-podautoscaling-docs branch 3 times, most recently from 03624cb to 830386c Compare February 18, 2025 01:03
@nwangfw
Copy link
Collaborator Author

nwangfw commented Feb 18, 2025

@Jeffwan Thanks for your comments and they make perfect senses. I have modified the commit accordingly and please review it again.

@Jeffwan Jeffwan force-pushed the ning/gpu-optimizer-podautoscaling-docs branch from 830386c to a75fb2d Compare February 18, 2025 05:55
@Jeffwan
Copy link
Collaborator

Jeffwan commented Feb 18, 2025

I append minor changes to this PR due to conflict from my previous change here. #697

Copy link
Collaborator

@Jeffwan Jeffwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Jeffwan Jeffwan merged commit 00d102c into main Feb 18, 2025
2 checks passed
@Jeffwan Jeffwan deleted the ning/gpu-optimizer-podautoscaling-docs branch February 18, 2025 05:57
gangmuk pushed a commit that referenced this pull request Feb 19, 2025
* add opimizer-based autoscaling doc and examples

* update doc structure and simply doc and yaml

* Fix a rst syntax issue

---------

Co-authored-by: Jiaxin Shan <[email protected]>
varungup90 pushed a commit that referenced this pull request Feb 20, 2025
* add opimizer-based autoscaling doc and examples

* update doc structure and simply doc and yaml

* Fix a rst syntax issue

---------

Co-authored-by: Jiaxin Shan <[email protected]>
Signed-off-by: Varun Gupta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants