Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Polish feature examples and user guidances #686

Merged
merged 6 commits into from
Feb 17, 2025
Merged

Conversation

Jeffwan
Copy link
Collaborator

@Jeffwan Jeffwan commented Feb 17, 2025

Pull Request Description

  1. Remove some volcano engine images reference and replace with dockerhub ones
  2. Fix some outdated examples
  3. Use more code with real deployment information rather than mocked app information

Related Issues

Resolves: #[Insert issue number(s)]

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@Jeffwan Jeffwan force-pushed the jiaxin/cleanup-0216 branch from de82809 to 7e30b5b Compare February 17, 2025 00:22
@Jeffwan Jeffwan merged commit 102fa59 into main Feb 17, 2025
2 checks passed
@Jeffwan Jeffwan deleted the jiaxin/cleanup-0216 branch February 17, 2025 00:23
gangmuk pushed a commit that referenced this pull request Feb 19, 2025
* fix the list display issue

* Update the quick start tutorials and model manifest

1. use create instead of apply
2. use ClusterIP for model deployment
3. update tutorial to expose external ip in elegant way

* Polish the gateway plugin docs

* Update the lora samples and guidance

* Update distributed kv cache example

* Update multi-node inference examples
varungup90 pushed a commit that referenced this pull request Feb 20, 2025
* fix the list display issue

* Update the quick start tutorials and model manifest

1. use create instead of apply
2. use ClusterIP for model deployment
3. update tutorial to expose external ip in elegant way

* Polish the gateway plugin docs

* Update the lora samples and guidance

* Update distributed kv cache example

* Update multi-node inference examples

Signed-off-by: Varun Gupta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant