Leverage literalinclude to keep only one code copy and move autoscaler configs to annotations #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiaxin Shan <[email protected]>
This is to avoid duplication. literalinclude perfectly helps address such issue. We just need to maintain the example code files and doc will be automatically updated. Signed-off-by: Jiaxin Shan <[email protected]>
Signed-off-by: Jiaxin Shan <[email protected]>
kerthcet
reviewed
Feb 13, 2025
kerthcet
reviewed
Feb 13, 2025
gangmuk
pushed a commit
that referenced
this pull request
Feb 13, 2025
Jeffwan
pushed a commit
that referenced
this pull request
Feb 13, 2025
* fixed manifest with name without v100, recording per request log in pod log streaming, updated script to use deploy.yaml instead of reusing existing deployment * fixed the indentations (two spaces) * Reformat autoscaler yamls based on #665 --------- Co-authored-by: Gangmuk <[email protected]>
varungup90
pushed a commit
that referenced
this pull request
Feb 20, 2025
…r configs to annotations (#665) * Move auotscaling configs to annotations and reformat files * Leverage existing sample files in docs This is to avoid duplication. literalinclude perfectly helps address such issue. We just need to maintain the example code files and doc will be automatically updated. * Move autoscaler configurations to annotations * Address code review feedbacks * Remove the empty lines --------- Signed-off-by: Jiaxin Shan <[email protected]> Signed-off-by: Varun Gupta <[email protected]>
varungup90
pushed a commit
that referenced
this pull request
Feb 20, 2025
* fixed manifest with name without v100, recording per request log in pod log streaming, updated script to use deploy.yaml instead of reusing existing deployment * fixed the indentations (two spaces) * Reformat autoscaler yamls based on #665 --------- Co-authored-by: Gangmuk <[email protected]> Signed-off-by: Varun Gupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
literalincludeto refer the sample code. In the end, we just need to maintain one code copy which is much easier.Related Issues
Resolves: #664
Important: Before submitting, please complete the description above and review the checklist below.
Contribution Guidelines (Expand for Details)
We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Bug]: Corrections to existing functionality[CI]: Changes to build process or CI pipeline[Docs]: Updates or additions to documentation[API]: Modifications to aibrix's API or interface[CLI]: Changes or additions to the Command Line Interface[Misc]: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use multiple prefixes in order of importance.
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.