Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AIBRIX_POD_METRIC_REFRESH_INTERVAL_MS=50 in base configs #640

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

Jeffwan
Copy link
Collaborator

@Jeffwan Jeffwan commented Feb 6, 2025

Pull Request Description

change AIBRIX_POD_METRIC_REFRESH_INTERVAL_MS in default setting is kind of risky. Some overlay refer the kustomization config without overriding the configs. I consider to override in overlay but notice 10000 is just for testing, then I decide to change back to 50 so people who work on testing can manually update it or create a separate dev overlay. Default should be used by most of the production setups.

Related Issues

Resolves: #[Insert issue number(s)]

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@Jeffwan Jeffwan requested a review from varungup90 February 6, 2025 23:46
@Jeffwan Jeffwan merged commit 951a7c5 into main Feb 7, 2025
7 checks passed
@Jeffwan Jeffwan deleted the jiaxin/use-separate-interval-for-vke branch February 7, 2025 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants