Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if model name is present in response from inference engine #611

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Check if model name is present in response from inference engine #611

merged 1 commit into from
Jan 27, 2025

Conversation

varungup90
Copy link
Collaborator

@varungup90 varungup90 commented Jan 27, 2025 •
edited by Jeffwan
Loading

Address #601

Jeffwan
Jeffwan approved these changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@Jeffwan Jeffwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

this is compatible with lora change

@Jeffwan Jeffwan merged commit 646904b into main Jan 27, 2025
10 checks passed
@Jeffwan Jeffwan deleted the check-response-model branch January 27, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeffwan Jeffwan Jeffwan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varungup90 @Jeffwan