Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the PodAutoscaler kind typo #610

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Conversation

Jeffwan
Copy link
Collaborator

@Jeffwan Jeffwan commented Jan 25, 2025

Pull Request Description

Due to this typo, hpa object can not be deleted by GC controller, it shows “unable to get REST mapping for autoscaling.aibrix.ai/v1alpha1/PodAutoScaler” error. However, HPA does work well and we didn’t notice this earlier

Related Issues

Resolves: #581

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

Due to this typo,  hpa object can not be deleted by GC controller, it shows “unable to get REST mapping for autoscaling.aibrix.ai/v1alpha1/PodAutoScaler” error.  However, HPA does work well and we didn’t notice this earlier

Signed-off-by: Jiaxin Shan <[email protected]>
@Jeffwan Jeffwan merged commit 355aff6 into main Jan 27, 2025
10 checks passed
@Jeffwan Jeffwan deleted the jiaxin/fix-autoscaler-hpa-kind-bug branch January 27, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HPA object is not deleted along with PA object deletion
2 participants