Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve condition update and fix multiple endpoint ips issue #609

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

Jeffwan
Copy link
Collaborator

@Jeffwan Jeffwan commented Jan 25, 2025

Pull Request Description

  • Update conditions to reflect correct status. time have been updated.
  • multiple endpoints issues in lora case has been addressed.

image

image
Only one ip now.

Related Issues

Resolves: #602 #600

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

multiple endpoint ips issues has been resolved as well

Signed-off-by: Jiaxin Shan <[email protected]>
@Jeffwan Jeffwan merged commit 222b170 into main Jan 27, 2025
10 checks passed
@Jeffwan Jeffwan deleted the jiaxin/0.2.0-bugs-lora branch January 27, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lora come back to normal but doesn't update the new condition
2 participants