-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support distributed kv cache orchestration #583
Conversation
Signed-off-by: Jiaxin Shan <[email protected]>
Signed-off-by: Jiaxin Shan <[email protected]>
Signed-off-by: Jiaxin Shan <[email protected]>
Signed-off-by: Jiaxin Shan <[email protected]>
Signed-off-by: Jiaxin Shan <[email protected]>
Signed-off-by: Jiaxin Shan <[email protected]>
Signed-off-by: Jiaxin Shan <[email protected]>
9d497e0
to
787c672
Compare
func needsUpdateDeployment(deployment *appsv1.Deployment, found *appsv1.Deployment) bool { | ||
imageChanged := false | ||
for i, container := range found.Spec.Template.Spec.Containers { | ||
if len(deployment.Spec.Template.Spec.Containers) > i { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can also have a scenario where number of containers are not same. Second, better to have a second loop to match by container name rather than depending on the container index (removes the assumption part). This can be a future TODO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are great suggestions. Sure, I create a new issue to track your proposed improvements #587.
I will merge this issue now and finish Varun's suggestion in later PRs. |
* Add kv cache api or distributed kv orchestration * Update the kvcache api spec * Add KV Cache controller initial implementation * Support affinity Node & Pod settings * Adjust manifest to orchestration folders * fix the ci check * Address review feedback * Update code based on rebase refactor * Fix the linter issue --------- Signed-off-by: Jiaxin Shan <[email protected]>
Pull Request Description
Support distributed kv cache orchestration #570
KVCache
, it will create the etcd, cache dataplane and necessary service for vLLM engine to communicate withExample
it will create following resources
cache deployment
individual pod
services
Related Issues
Resolves: #570
Important: Before submitting, please complete the description above and review the checklist below.
Contribution Guidelines (Expand for Details)
We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Bug]
: Corrections to existing functionality[CI]
: Changes to build process or CI pipeline[Docs]
: Updates or additions to documentation[API]
: Modifications to aibrix's API or interface[CLI]
: Changes or additions to the Command Line Interface[Misc]
: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use multiple prefixes in order of importance.
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.