Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the HPA ownerReference in request enqueue #582

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

Jeffwan
Copy link
Collaborator

@Jeffwan Jeffwan commented Jan 21, 2025

Pull Request Description

Related Issues

Resolves: #463

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@Jeffwan Jeffwan requested a review from kr11 January 21, 2025 00:10
@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Jan 21, 2025

@kr11 approved the PR in the group chat, I will merge it directly.

@Jeffwan Jeffwan merged commit 7c5a18c into main Jan 21, 2025
10 checks passed
@Jeffwan Jeffwan deleted the jiaxin/release-misc-updates branch January 21, 2025 07:23
gangmuk pushed a commit that referenced this pull request Jan 25, 2025
* Update runtime api with guidance on nightly install

* Update PodAutoscaler to only enqueue managed objects

---------

Signed-off-by: Jiaxin Shan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant