Support model registration flow using aibrix runtime api #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brosoul
reviewed
Jan 21, 2025
brosoul
reviewed
Jan 21, 2025
brosoul
reviewed
Jan 21, 2025
|
overall lgtm |
Signed-off-by: Jiaxin Shan <[email protected]>
Signed-off-by: Jiaxin Shan <[email protected]>
Signed-off-by: Jiaxin Shan <[email protected]>
1. hugginface protocol shadow assignment bug 2. wrong runtime port 3. wrong host used in buildurls 4. can not forward entire headers due to content length mismatch Signed-off-by: Jiaxin Shan <[email protected]>
Signed-off-by: Jiaxin Shan <[email protected]>
Jeffwan
force-pushed
the
jiaxin/switch-to-runtime-api
branch
from
5805f1e to
0e8542b
Compare
varungup90
approved these changes
Jan 21, 2025
gangmuk
pushed a commit
that referenced
this pull request
Jan 25, 2025
* Introduce RuntimeConfig to all controllers * Refactor the logic to construct URLs based on different envs * Leverage runtime api to manage lora load & unload * Fix several bugs 1. hugginface protocol shadow assignment bug 2. wrong runtime port 3. wrong host used in buildurls 4. can not forward entire headers due to content length mismatch * Format files * Address code review feedback --------- Signed-off-by: Jiaxin Shan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
If user specify
- --enable-runtime-sidecarin controller manager, controller will try to talk with runtime sidecar instead of engine directly. this is to promote our runtime model management api work and this is also good to build abstraction from different engines.Add
/v1/modelslisting api in runtime which is missing in the past and lora adapter does relies on this feature to fetch existing adapters and base model.Related Issues
Resolves: #567 #521 (partial) #49 (partial)
Important: Before submitting, please complete the description above and review the checklist below.
Contribution Guidelines (Expand for Details)
We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Bug]: Corrections to existing functionality[CI]: Changes to build process or CI pipeline[Docs]: Updates or additions to documentation[API]: Modifications to aibrix's API or interface[CLI]: Changes or additions to the Command Line Interface[Misc]: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use multiple prefixes in order of importance.
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.