Mock app log fix for missing metrics warning #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeffwan
reviewed
Jan 9, 2025
| metrics_output = """ | ||
| # HELP vllm:lora_requests_info Running stats on lora requests. | ||
| # TYPE vllm:lora_requests_info gauge | ||
| vllm:lora_requests_info{max_lora="1",running_lora_adapters="text2sql-lora-1",waiting_lora_adapters=""} 1 |
There was a problem hiding this comment.
do you have dynamic lora information, should it be a rendered template with lora names?
There was a problem hiding this comment.
I will merge this and create a follow up task to generate dynamic lora information.
|
rest part looks good to me |
Jeffwan
approved these changes
Jan 9, 2025
gangmuk
pushed a commit
that referenced
this pull request
Jan 25, 2025
* Add lora_info log message and misc README.md naming cleanup * nit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#491