-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] heterogenous gpu docs added #545
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should further document
- How podautoscaler should configured to read metricsSources
- The new label I added to the deployment as "model.aibrix.ai/min_replicas" in
apiVersion: apps/v1
kind: Deployment
metadata:
name: simulator-llama2-7b-a100
labels:
model.aibrix.ai/name: "llama2-7b"
model.aibrix.ai/min_replicas: "1" # min replica for gpu optimizer when no workloads.
kubectl -n aibrix-system port-forward svc/aibrix-redis-master 6379:6379 1>/dev/null 2>&1 & | ||
|
||
cd $AIBRIX_HOME/python/aibrix/aibrix/gpu_optimizer | ||
make DP=simulator-llama2-7b-a100 COST=0.1gen-profile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a typo here: missing " " before gen-profile. Plus. it will be better to set cost of A100 large than a40, e.g., cost=1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhangjyr can you take another look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a typo here: missing " " before gen-profile. Plus. it will be better to set cost of A100 large than a40, e.g., cost=1
Thanks for finding this typo. I intended to type 1.0 rather then 0.1.
Thanks for your suggestions. I have added two new parts accordingly. |
4473827
to
fade25a
Compare
* heterogenous gpu docs added * added podAutoscaler and minReplicas config
Pull Request Description
A blog post introducing heterogeneous GPU inference, along with a deployment example is added.
Related Issues
Partially resolves: #390
Important: Before submitting, please complete the description above and review the checklist below.
Contribution Guidelines (Expand for Details)
We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Bug]
: Corrections to existing functionality[CI]
: Changes to build process or CI pipeline[Docs]
: Updates or additions to documentation[API]
: Modifications to aibrix's API or interface[CLI]
: Changes or additions to the Command Line Interface[Misc]
: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use multiple prefixes in order of importance.
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.