Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure autoscaler http client to skip certificate check #530

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

Jeffwan
Copy link
Collaborator

@Jeffwan Jeffwan commented Dec 15, 2024

Pull Request Description

Configure autoscaler http client to skip certificate check

Related Issues

Resolves: #528

img_v3_02hk_4ec705a1-4725-4c61-9520-9373f1c4b71h

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@Jeffwan Jeffwan requested a review from kr11 December 15, 2024 18:00
@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Dec 15, 2024

Since VKE is asking this and this test pass the e2e testing, I feel we can merge this now. @kr11 feel free to review it and the original issue, we can address remaining problems in future PRs.

@Jeffwan Jeffwan merged commit 4cf1ee2 into main Dec 15, 2024
10 checks passed
@Jeffwan Jeffwan deleted the jiaxin/fix-tls-issue branch December 15, 2024 18:09
gangmuk pushed a commit that referenced this pull request Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

autoscaler failed to fetch https endpoint
1 participant