Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Polish the benchmark scripts #525

Merged
merged 5 commits into from
Dec 17, 2024
Merged

Conversation

Jeffwan
Copy link
Collaborator

@Jeffwan Jeffwan commented Dec 13, 2024

Pull Request Description

  1. Rename some variables for self-explaination and rename the output files by removing empty lines
  2. mkdir the —output-dir if it doesn’t exist, and add output folder name to .gitignore
  3. Change the triple quote markdown to single quote in single line.
  4. Reformat all generator codes
  5. Change the logging level
  6. Add duration check for tracing files and fallback to right duration if it's over the limit

Related Issues

Resolves: #523

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

1. Rename some variables for self-explaination and rename the output files by removing empty lines
2. mkdir the —output-dir if it doesn’t exist, and add output folder name to .gitignore
3. Change the triple quote markdown to single quote in single line.
4. Reformat all generator codes

Signed-off-by: Jiaxin Shan <[email protected]>
Signed-off-by: Jiaxin Shan <[email protected]>
Signed-off-by: Jiaxin Shan <[email protected]>
Signed-off-by: Jiaxin Shan <[email protected]>
@Jeffwan Jeffwan requested review from happyandslow and kr11 December 13, 2024 20:08
@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Dec 17, 2024

@happyandslow do you get a chance to look at this change?

@Jeffwan Jeffwan merged commit 0755fa9 into main Dec 17, 2024
2 checks passed
@Jeffwan Jeffwan deleted the jiaxin/impprove-benchmark-tool branch December 17, 2024 21:52
gangmuk pushed a commit that referenced this pull request Jan 25, 2025
* Polish the benchmark scripts

1. Rename some variables for self-explaination and rename the output files by removing empty lines
2. mkdir the —output-dir if it doesn’t exist, and add output folder name to .gitignore
3. Change the triple quote markdown to single quote in single line.
4. Reformat all generator codes

* Reduce the duplication in workload generation

* clean up

* Fix the timestamp issue

* fix some issues

---------

Signed-off-by: Jiaxin Shan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve the benchmark code quality and ease of use
2 participants