Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Heterogeneous GPU Optimizer Logging Clean Up #514

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

nwangfw
Copy link
Collaborator

@nwangfw nwangfw commented Dec 10, 2024

Pull Request Description

In this PR, we clean up the GPU optimizer's logging information.

(1) using snake case format
(2) Removed uvicorn.error, which is confusing
(3) modified the default GPU cost from 0 to inf, In this case, the OPU optimizer will never use a GPU type without profiling.

Related Issues

Resolves: #502

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@nwangfw nwangfw requested review from zhangjyr and Jeffwan December 10, 2024 16:20
@nwangfw nwangfw changed the title Heterogeneous GPU Optimizer Logging Clean Up [MISC] Heterogeneous GPU Optimizer Logging Clean Up Dec 10, 2024
@nwangfw nwangfw force-pushed the ning/gpu-optimizer-load-monitoring-logging-clean branch from 978e9b0 to bf07312 Compare December 10, 2024 16:38
@nwangfw nwangfw force-pushed the ning/gpu-optimizer-load-monitoring-logging-clean branch from bf07312 to 098db8e Compare December 10, 2024 16:56
@Jeffwan
Copy link
Collaborator

Jeffwan commented Dec 10, 2024

excellent! this helps a lot in our observation

@Jeffwan Jeffwan changed the title [MISC] Heterogeneous GPU Optimizer Logging Clean Up [Misc] Heterogeneous GPU Optimizer Logging Clean Up Dec 10, 2024
Copy link
Collaborator

@Jeffwan Jeffwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me

@Jeffwan Jeffwan merged commit 98b5ca4 into main Dec 10, 2024
10 checks passed
@Jeffwan Jeffwan deleted the ning/gpu-optimizer-load-monitoring-logging-clean branch December 10, 2024 18:37
gangmuk pushed a commit that referenced this pull request Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up gpu-optimizer logging
2 participants