-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[perf] Refact tos downloader in Runtime #510
Conversation
4bbc9a1
to
5b2f729
Compare
} | ||
|
||
|
||
class TOSDownloader(S3BaseDownloader): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, can we keep the tos file and move TOSDownloader to tos.py?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks good to me. I left some comments on legacy codes and file should store TosDownloader
cc @Jeffwan
During the comparison process, we can draw the following conclusions:
|
great. this is excellent! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems all comments have been addressed. LGTM
* refact: refact TOSDownloader use boto * test: fix test case after refact * fix: download all the directory failed * style * feat: set max memory avaiable while download * fix dependency * refact: move the action that filter file from folder into * style * refact: keep origin tos downloader implement and add version control env * test: fix test * fix test * style * misc: use better envs config
Pull Request Description
DOWNLOADER_S3_MAX_IO_QUEUE
andDOWNLOADER_S3_IO_CHUNKSIZE
to control the memory could be used during downloadingTODO: find suitable envs settings for
MAX_IO_QUEUE
andS3_IO_CHUNKSIZE
.Related Issues
Resolves: #320 , #358
Important: Before submitting, please complete the description above and review the checklist below.
Contribution Guidelines (Expand for Details)
We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Bug]
: Corrections to existing functionality[CI]
: Changes to build process or CI pipeline[Docs]
: Updates or additions to documentation[API]
: Modifications to aibrix's API or interface[CLI]
: Changes or additions to the Command Line Interface[Misc]
: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use multiple prefixes in order of importance.
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.