Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Improve gpu optimizer debugging on podautoscaler. #509

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

zhangjyr
Copy link
Collaborator

@zhangjyr zhangjyr commented Dec 9, 2024

Pull Request Description

The PR includes the config overlay to enable GPU optimizer and controller manager debugging.
GPU optimizer enables metrics overriding to improve podautoscaling debug efficiency.
An essential pod autoscaling configuration was added to accelerate the pod scaling down.

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@nwangfw
Copy link
Collaborator

nwangfw commented Dec 9, 2024

looks good to me overall

@Jeffwan Jeffwan merged commit 6e6016f into main Dec 10, 2024
10 checks passed
@Jeffwan Jeffwan deleted the jingyuan/gpu_optimizer_debugging branch December 10, 2024 00:36
gangmuk pushed a commit that referenced this pull request Jan 25, 2025
* Enable gpu optimizer debugging on scaling.

* Lint fix

* Remove unnecessary config/overlay/dev/default

---------

Co-authored-by: Jingyuan Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants