-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] Integrate deployment configurations and fix autoscaler/gpu optimizer connectivity #500
[Feat] Integrate deployment configurations and fix autoscaler/gpu optimizer connectivity #500
Conversation
…l namespaces with model label.
…_failed_to_fetch_metrics_from_MetricSource # Conflicts: # development/simulator/deployment-a100.yaml # development/simulator/deployment-a40.yaml
I moved some comments from #480 here: |
Right now, we are modifying code under python/aibrix/aibrix/gpu_optimizer. Can we delete python/aibrix/aibrix/gpuoptimizer folder? |
@nwangfw we should not have such folder? upstream folder has been renamed |
Never mind. Seems that it has been deleted. Please ignore it and thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
…imizer connectivity (#500) * Add GPU Optimizer deployment and update configurations * Fix k8s accessibility regard namespaces. GPU optimizer now monitor all namespaces with model label. * Lint fix * Deployment clean-up * Update README.md --------- Co-authored-by: Ning Wang <[email protected]> Co-authored-by: Jingyuan Zhang <[email protected]>
Pull Request Description
This PR fixed the connectivity problem between podautoscaler and GPU optimizer by:
Note: I keep the deployment.yaml under GPU optimizer undeleted for debugging purposes.
Related Issues
Resolves: #484 #480 #459
Important: Before submitting, please complete the description above and review the checklist below.
Contribution Guidelines (Expand for Details)
We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Bug]
: Corrections to existing functionality[CI]
: Changes to build process or CI pipeline[Docs]
: Updates or additions to documentation[API]
: Modifications to aibrix's API or interface[CLI]
: Changes or additions to the Command Line Interface[Misc]
: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use multiple prefixes in order of importance.
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.