Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor generator to generate time-based traces #478

Merged
merged 9 commits into from
Dec 5, 2024

Conversation

happyandslow
Copy link
Collaborator

@happyandslow happyandslow commented Dec 4, 2024

This commit adds

  • Leading timestamp for each concurrent dispatch
  • Force include input/output token lengths in the dataset
  • Option to store as .jsonl

@happyandslow happyandslow changed the title Refactor generator to generate time-based traces [WIP] Refactor generator to generate time-based traces Dec 4, 2024
@happyandslow happyandslow changed the title [WIP] Refactor generator to generate time-based traces Refactor generator to generate time-based traces Dec 5, 2024
@Jeffwan
Copy link
Collaborator

Jeffwan commented Dec 5, 2024

Can you also share a generated code sample? I highly suggest to switch to jsonl by default. this is easy to parse and split.

@Jeffwan
Copy link
Collaborator

Jeffwan commented Dec 5, 2024

I am ok with --duration-ms at this moment. overall looks good to me

@happyandslow happyandslow force-pushed the lexu/trace-generator-ts branch from 6f9d0d6 to a3ea613 Compare December 5, 2024 20:59
@happyandslow
Copy link
Collaborator Author

Sample .json format
Quick Rising.json.zip

Sample .jsonl format
Quick Rising.jsonl.zip

@Jeffwan Jeffwan merged commit aa77efb into main Dec 5, 2024
2 checks passed
@Jeffwan Jeffwan deleted the lexu/trace-generator-ts branch December 5, 2024 21:40
zhangjyr pushed a commit that referenced this pull request Dec 5, 2024
gangmuk pushed a commit that referenced this pull request Jan 25, 2025
* adding timestamp and prompt in/output length to traces

* name fix; plotting script fix

* update README

* addressing comments

* addressing comments

* add sample workload

* add sample workload

* update file format

* update jsonl option

---------

Co-authored-by: Le Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants