Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add health check api interface for runtime #451

Merged
merged 5 commits into from
Dec 2, 2024

Conversation

Jeffwan
Copy link
Collaborator

@Jeffwan Jeffwan commented Dec 1, 2024

Pull Request Description

  1. Add /healthz and /ready in runtime app server
  2. Update existing test deployments to include the health check and necessary env

Related Issues

Resolves: #177

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

1. Add /healthz and /ready in runtime app server
2. Update existing test deployments to include the health check and necessary env
@Jeffwan Jeffwan requested a review from brosoul December 1, 2024 18:57
@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Dec 2, 2024

test failed due to the nightly image tag is not loaded into kind env. Only specific commit id is loaded but that's hard to test the mocked app and it fetch it from the remote registry

Copy link
Collaborator

@brosoul brosoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brosoul brosoul merged commit a76686f into main Dec 2, 2024
10 checks passed
@brosoul brosoul deleted the jiaixn/api-runtime-health-check branch December 2, 2024 03:22
gangmuk pushed a commit that referenced this pull request Jan 25, 2025
* Add health check api interface for runtime

1. Add /healthz and /ready in runtime app server
2. Update existing test deployments to include the health check and necessary env

* Fix the format issue

* Remove model mount in the mocked app deployment

* Use night tag to test current image

* Update ci workflow to load nightly images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add health check api interface for AI Runtime
2 participants