Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CrashLoopBackOff status detection in CI #444

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

nwangfw
Copy link
Collaborator

@nwangfw nwangfw commented Nov 27, 2024

Pull Request Description

A workload deployment is added into the integration test to detect one CrashLoopBackOff error missed in previous integration test.

Related Issues

Resolves: #440

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@nwangfw nwangfw force-pushed the ning/integration-test-missing-error branch 3 times, most recently from 16985be to 88782c1 Compare November 27, 2024 22:46
@nwangfw nwangfw changed the title CrashLoopBackOff status detect in CI CrashLoopBackOff status detection in CI Nov 27, 2024
@nwangfw nwangfw force-pushed the ning/integration-test-missing-error branch 5 times, most recently from a839591 to 18ac66e Compare November 28, 2024 19:27
@nwangfw nwangfw force-pushed the ning/integration-test-missing-error branch from 18ac66e to 1243021 Compare November 28, 2024 19:35
@nwangfw nwangfw marked this pull request as ready for review November 28, 2024 20:00
@Jeffwan
Copy link
Collaborator

Jeffwan commented Nov 29, 2024

Nice finding! We finally figure this out!

@Jeffwan Jeffwan merged commit 17cceea into main Nov 29, 2024
2 checks passed
@Jeffwan Jeffwan deleted the ning/integration-test-missing-error branch November 29, 2024 06:11
gangmuk pushed a commit that referenced this pull request Jan 25, 2025
CrashLoopBackOff status detect in CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] integration test failed to detect the bugs
2 participants