-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Nightly tag removed for release branch #422
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.github/workflows/docker-push-images.yml
is for main branch image pushing, it should be always nightly. Let's update the release workflow.- there's no need to override the tag, we can simplicity use enable or not, like a boolean here.
- by default night tag should be enabled, if not, let's skip nightly build & push
Alternatively, we can check git_commit_hash is ref_name or commit hash. if that can be done, we can choose that way as well
4a99629
to
960349f
Compare
960349f
to
a6c35ec
Compare
Modified based on your suggestions. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the change looks good to me
Nightly tag removed for release branch
[CI] Nightly tag removed for release branch (#422) Nightly tag removed for release branch
Nightly tag removed for release branch
Pull Request Description
Fixed the issue that previously tagged branches also get "nightly" tag
Related Issues
Resolves: #315
Important: Before submitting, please complete the description above and review the checklist below.
Contribution Guidelines (Expand for Details)
We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Bug]
: Corrections to existing functionality[CI]
: Changes to build process or CI pipeline[Docs]
: Updates or additions to documentation[API]
: Modifications to aibrix's API or interface[CLI]
: Changes or additions to the Command Line Interface[Misc]
: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use multiple prefixes in order of importance.
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.