Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Nightly tag removed for release branch #422

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

nwangfw
Copy link
Collaborator

@nwangfw nwangfw commented Nov 20, 2024

Pull Request Description

Fixed the issue that previously tagged branches also get "nightly" tag

Related Issues

Resolves: #315

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@nwangfw nwangfw changed the title Nightly tag removed for release branch [CI] Nightly tag removed for release branch Nov 20, 2024
@nwangfw nwangfw requested a review from Jeffwan November 20, 2024 23:39
Copy link
Collaborator

@Jeffwan Jeffwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. .github/workflows/docker-push-images.yml is for main branch image pushing, it should be always nightly. Let's update the release workflow.
  2. there's no need to override the tag, we can simplicity use enable or not, like a boolean here.
  3. by default night tag should be enabled, if not, let's skip nightly build & push

Alternatively, we can check git_commit_hash is ref_name or commit hash. if that can be done, we can choose that way as well

@Jeffwan Jeffwan marked this pull request as ready for review November 21, 2024 00:09
@nwangfw nwangfw force-pushed the fix-branch-relesase-tag branch 6 times, most recently from 4a99629 to 960349f Compare November 21, 2024 01:29
@nwangfw nwangfw force-pushed the fix-branch-relesase-tag branch from 960349f to a6c35ec Compare November 21, 2024 01:31
@nwangfw
Copy link
Collaborator Author

nwangfw commented Nov 21, 2024

  1. .github/workflows/docker-push-images.yml is for main branch image pushing, it should be always nightly. Let's update the release workflow.
  2. there's no need to override the tag, we can simplicity use enable or not, like a boolean here.
  3. by default night tag should be enabled, if not, let's skip nightly build & push

Alternatively, we can check git_commit_hash is ref_name or commit hash. if that can be done, we can choose that way as well

Modified based on your suggestions. Thanks!

Copy link
Collaborator

@Jeffwan Jeffwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change looks good to me

@Jeffwan Jeffwan merged commit 703c4f6 into main Nov 21, 2024
7 checks passed
@Jeffwan Jeffwan deleted the fix-branch-relesase-tag branch November 21, 2024 04:58
nwangfw added a commit that referenced this pull request Jan 9, 2025
Nightly tag removed for release branch
Jeffwan pushed a commit that referenced this pull request Jan 10, 2025
[CI] Nightly tag removed for release branch (#422)

Nightly tag removed for release branch
gangmuk pushed a commit that referenced this pull request Jan 25, 2025
Nightly tag removed for release branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] release branch trigger workflow also tag nightly tag which is incorrect
2 participants