Misc: add support to metricsSources property of podautoscaler #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will cut v0.1.0 release today and then come back to review and merge this change |
Jeffwan
reviewed
Nov 14, 2024
|
|
||
| if exists && value == "on" { | ||
| // 30080 is the nodePort of the base model service. | ||
| url = fmt.Sprintf("http://%s:8000/metrics", "localhost") |
There was a problem hiding this comment.
the fixed value was for local desktop testing. removing it produce stops dev working as expected. this is ok for standarization. just take this note if testing doesn't work. @kr11 We need to pass the fixed port from client side.
|
Overall, I think the refactor makes sense and looks good to me. |
Jeffwan
approved these changes
Nov 14, 2024
|
@kr11 Feel free to leave comments and we can ask Jingyuan to help address it in next PR. I will merge this one first |
gangmuk
pushed a commit
that referenced
this pull request
Jan 25, 2025
Add support to metricsSources Co-authored-by: Jingyuan Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Currently, the metricsSources property in podAutoScaler is not considered. This pull request adds support to metricsSources, which will override the default KPA behavior that reads metrics from the model pods. In this pull request, only one metricsSource is supported. Extra metricsSources will be ignored.
Related Issues
Resolves: #[Insert issue number(s)]
Important: Before submitting, please complete the description above and review the checklist below.
Contribution Guidelines (Expand for Details)
We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Bug]: Corrections to existing functionality[CI]: Changes to build process or CI pipeline[Docs]: Updates or additions to documentation[API]: Modifications to aibrix's API or interface[CLI]: Changes or additions to the Command Line Interface[Misc]: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use multiple prefixes in order of importance.
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.