Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the mocked app to cleaner state #361

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

Jeffwan
Copy link
Collaborator

@Jeffwan Jeffwan commented Nov 11, 2024

Pull Request Description

  1. Remove useless files, users should always follow the top level README.md to install the control plan, this is the mocked app folder and people should leverage mocked app from there rather than any other aibrix components. This is good for consistency as well.

  2. Change app namespace from aibrix-system to default. The old deployment in aibrix-system hides a lots of edge cases and issues, in real world envs, we won’t deploy data plane workloads in control plane namespace. Change to default to mock the real case.

  3. Update README.md structure and make it cleaner to adopt above changes

Related Issues

Resolves: #365

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

1. Remove useless files, users should always follow the top level README.md to install the control plan, this is the mocked app folder and people should leverage mocked app from there rather than any other aibrix components. This is good for consistency as well.

2. Change app namespace from aibrix-system to default. The old deployment in aibrix-system hides a lots of edge cases and issues, in real world envs, we won’t deploy data plane workloads in control plane namespace. Change to default to mock the real case.

3. Update README.md structure and make it cleaner to adopt above changes
@Jeffwan Jeffwan merged commit aa5edec into main Nov 11, 2024
9 checks passed
@Jeffwan Jeffwan deleted the jiaxin/update-mock-app branch November 11, 2024 18:32
gangmuk pushed a commit that referenced this pull request Jan 25, 2025
1. Remove useless files, users should always follow the top level README.md to install the control plan, this is the mocked app folder and people should leverage mocked app from there rather than any other aibrix components. This is good for consistency as well.

2. Change app namespace from aibrix-system to default. The old deployment in aibrix-system hides a lots of edge cases and issues, in real world envs, we won’t deploy data plane workloads in control plane namespace. Change to default to mock the real case.

3. Update README.md structure and make it cleaner to adopt above changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up mocked app to be more accurate
2 participants